Inbjudningslänkar, adressuppslag för kartregistret och närvaromärke
Böcker kan delas med en inbjudningslänk (roll, giltighetstid, en eller flera personer, bara en hash sparas). Inloggningen går tillbaka till inbjudan. Kartregistrets markeringar kan få position genom uppslag mot karttjänsten, ett i sekunden. Redigeringsformulär och listor visar vem som har något öppet för redigering. Migrering 0009. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
1fd1ce78cb
commit
5c58f70bdd
34 files changed
+1610
-30
No files matched your search
@@ -0,0 +1,153 @@
|
||||
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
||||
import { clearGeocodeCache, distanceKm, geocode, geocodingEnabled, validPosition } from "@/lib/geocode";
|
||||
import { safeCallbackPath } from "@/lib/redirect";
|
||||
|
||||
describe("distanceKm", () => {
|
||||
it("räknar avstånd mellan städer", () => {
|
||||
expect(distanceKm({ lat: 55.7047, lng: 13.191 }, { lat: 55.7047, lng: 13.191 })).toBe(0);
|
||||
expect(Math.round(distanceKm({ lat: 55.6761, lng: 12.5683 }, { lat: 59.3293, lng: 18.0686 }))).toBeGreaterThan(500); // Köpenhamn–Stockholm
|
||||
expect(Math.round(distanceKm({ lat: 55.7047, lng: 13.191 }, { lat: 55.6050, lng: 13.0038 }))).toBeLessThan(25); // Lund–Malmö
|
||||
});
|
||||
});
|
||||
|
||||
describe("validPosition", () => {
|
||||
it("godtar bara riktiga koordinater", () => {
|
||||
expect(validPosition({ lat: 55.7, lng: 13.2 })).toBe(true);
|
||||
expect(validPosition({ lat: 90, lng: -180 })).toBe(true);
|
||||
expect(validPosition({ lat: 91, lng: 0 })).toBe(false);
|
||||
expect(validPosition({ lat: 0, lng: 181 })).toBe(false);
|
||||
expect(validPosition({ lat: Number.NaN, lng: 0 })).toBe(false);
|
||||
expect(validPosition({ lat: "55" as unknown as number, lng: 13 })).toBe(false);
|
||||
expect(validPosition({ lat: undefined, lng: 13 })).toBe(false);
|
||||
expect(validPosition(null)).toBe(false);
|
||||
});
|
||||
});
|
||||
|
||||
describe("geocode", () => {
|
||||
const calls: { url: string; init?: RequestInit }[] = [];
|
||||
const answer = (rows: unknown, ok = true) => ({ ok, status: ok ? 200 : 503, json: async () => rows });
|
||||
|
||||
beforeEach(() => {
|
||||
calls.length = 0;
|
||||
clearGeocodeCache();
|
||||
process.env.GEOCODER_INTERVAL_MS = "0";
|
||||
delete process.env.MAP_GEOCODER_URL;
|
||||
delete process.env.GEOCODING_ENABLED;
|
||||
});
|
||||
afterEach(() => {
|
||||
vi.unstubAllGlobals();
|
||||
delete process.env.GEOCODER_INTERVAL_MS;
|
||||
delete process.env.MAP_GEOCODER_URL;
|
||||
delete process.env.GEOCODING_ENABLED;
|
||||
});
|
||||
|
||||
const stub = (handler: (url: string) => unknown) =>
|
||||
vi.stubGlobal(
|
||||
"fetch",
|
||||
vi.fn(async (url: string, init?: RequestInit) => {
|
||||
calls.push({ url, init });
|
||||
return handler(url);
|
||||
}),
|
||||
);
|
||||
|
||||
it("ger position och namn, och skickar en tydlig användaragent utan personuppgifter", async () => {
|
||||
stub(() => answer([{ lat: "55.7047", lon: "13.1910", display_name: "Lund, Skåne" }]));
|
||||
expect(await geocode(" Lund ")).toEqual({ lat: 55.7047, lng: 13.191, name: "Lund, Skåne" });
|
||||
expect(calls[0].url).toContain("nominatim.openstreetmap.org/search");
|
||||
expect(calls[0].url).toContain("q=Lund");
|
||||
expect(calls[0].url).toContain("limit=1");
|
||||
const headers = calls[0].init?.headers as Record<string, string>;
|
||||
expect(headers["User-Agent"]).toMatch(/^Bokplanerare\//);
|
||||
expect(headers["User-Agent"]).not.toContain("@");
|
||||
});
|
||||
|
||||
it("använder den adress som anges i MAP_GEOCODER_URL", async () => {
|
||||
process.env.MAP_GEOCODER_URL = "https://geo.example.com/sok";
|
||||
stub(() => answer([]));
|
||||
await geocode("Lund");
|
||||
expect(calls[0].url.startsWith("https://geo.example.com/sok?")).toBe(true);
|
||||
});
|
||||
|
||||
it("ger null när inget hittas, och för tomma eller trasiga svar", async () => {
|
||||
stub(() => answer([]));
|
||||
expect(await geocode("Finns inte")).toBeNull();
|
||||
stub(() => answer([{ lat: "abc", lon: "13" }]));
|
||||
expect(await geocode("Trasigt")).toBeNull();
|
||||
stub(() => answer([{ lat: "99", lon: "13" }]));
|
||||
expect(await geocode("Utanför")).toBeNull();
|
||||
stub(() => answer({ fel: true }));
|
||||
expect(await geocode("Objekt")).toBeNull();
|
||||
expect(await geocode(" ")).toBeNull();
|
||||
});
|
||||
|
||||
it("kastar när tjänsten inte svarar, och nästa fråga fungerar ändå", async () => {
|
||||
stub(() => answer([], false));
|
||||
await expect(geocode("Lund")).rejects.toThrow("503");
|
||||
stub(() => answer([{ lat: "1", lon: "2" }]));
|
||||
expect(await geocode("Malmö")).toMatchObject({ lat: 1, lng: 2 });
|
||||
});
|
||||
|
||||
it("sparar svaren, även när inget hittades, och skiljer inte på stora och små bokstäver", async () => {
|
||||
stub(() => answer([{ lat: "1", lon: "2" }]));
|
||||
await geocode("Lund");
|
||||
await geocode("lund");
|
||||
await geocode(" LUND ");
|
||||
expect(calls).toHaveLength(1);
|
||||
stub(() => answer([]));
|
||||
await geocode("Ingenstans");
|
||||
await geocode("Ingenstans");
|
||||
expect(calls).toHaveLength(2);
|
||||
});
|
||||
|
||||
it("köar anropen så att tjänsten får högst ett i sekunden", async () => {
|
||||
process.env.GEOCODER_INTERVAL_MS = "120";
|
||||
stub(() => answer([{ lat: "1", lon: "2" }]));
|
||||
const started = Date.now();
|
||||
await Promise.all(["A", "B", "C"].map((q) => geocode(q)));
|
||||
expect(Date.now() - started).toBeGreaterThanOrEqual(220);
|
||||
expect(calls).toHaveLength(3);
|
||||
});
|
||||
|
||||
it("kortar långa frågor och kodar tecken", async () => {
|
||||
stub(() => answer([]));
|
||||
await geocode(`Å&=?${"x".repeat(500)}`);
|
||||
const q = new URL(calls[0].url).searchParams.get("q")!;
|
||||
expect(q).toHaveLength(200);
|
||||
expect(q.startsWith("Å&=?")).toBe(true);
|
||||
});
|
||||
|
||||
it("kan stängas av", () => {
|
||||
expect(geocodingEnabled()).toBe(true);
|
||||
process.env.GEOCODING_ENABLED = "false";
|
||||
expect(geocodingEnabled()).toBe(false);
|
||||
});
|
||||
});
|
||||
|
||||
describe("safeCallbackPath", () => {
|
||||
const origin = "https://bocker.example.com";
|
||||
it("godtar adresser inom appen", () => {
|
||||
expect(safeCallbackPath("/invite/abc", origin)).toBe("/invite/abc");
|
||||
expect(safeCallbackPath("/books/1/settings?share=ok", origin)).toBe("/books/1/settings?share=ok");
|
||||
expect(safeCallbackPath("https://bocker.example.com/invite/abc?x=1", origin)).toBe("/invite/abc?x=1");
|
||||
});
|
||||
|
||||
it("avvisar andra sajter och knep", () => {
|
||||
for (const bad of ["https://evil.example.com/x", "//evil.example.com", "/\\evil.example.com", "javascript:alert(1)", "http://bocker.example.com.evil.com/", "evil.com", "/a\r\nSet-Cookie: x=1"]) {
|
||||
expect(safeCallbackPath(bad, origin)).toBe("/");
|
||||
}
|
||||
});
|
||||
|
||||
it("skickar inte tillbaka till inloggningen och klarar tomt", () => {
|
||||
expect(safeCallbackPath("/login", origin)).toBe("/");
|
||||
expect(safeCallbackPath("/login?callbackUrl=/x", origin)).toBe("/");
|
||||
expect(safeCallbackPath("/api/auth/signin", origin)).toBe("/");
|
||||
expect(safeCallbackPath("", origin)).toBe("/");
|
||||
expect(safeCallbackPath(undefined, origin)).toBe("/");
|
||||
expect(safeCallbackPath("/x".repeat(3000), origin)).toBe("/");
|
||||
});
|
||||
|
||||
it("utan känd adress godtas bara relativa adresser", () => {
|
||||
expect(safeCallbackPath("https://bocker.example.com/x", undefined)).toBe("/");
|
||||
expect(safeCallbackPath("/x", undefined)).toBe("/x");
|
||||
});
|
||||
});
|
||||
Reference in new issue
Block a user