Port presets: Windows client, Windows server and Debian / Ubuntu

Ready-made presets for what each OS has open out of the box. They are added once
to installs that already have presets (same-name presets untouched, emptied list
stays empty); a test checks no port is given two names across presets.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
bobbanandClaude Sonnet 5.5 committed 2026-11-16 23:39:29 +01:00
1 parent 06ac120a1d
commit 94288afcbd
4 files changed
+100 -10

No files matched your search

+44 -1
View File
@@ -150,12 +150,28 @@ describe("the routes", () => {
test("the ready-made presets are there the first time, for everyone", async () => {
const list = (await json<{ presets: Preset[] }>(await call("viewer", "GET", "/port-presets"))).presets;
assert.deepEqual(list.map((p) => p.name), ["Databases", "File sharing", "Homelab tools", "Remote access", "Web"]);
assert.deepEqual(list.map((p) => p.name), ["Databases", "Debian / Ubuntu", "File sharing", "Homelab tools", "Remote access", "Web", "Windows client", "Windows server"]);
const remote = list.find((p) => p.name === "Remote access")!;
assert.deepEqual(remote.ports.map((p) => [p.port, p.label]), [[22, "SSH"], [3389, "RDP"], [5900, "VNC"], [5985, "WinRM (HTTP)"], [5986, "WinRM (HTTPS)"]]);
assert.ok(list.find((p) => p.name === "Databases")!.ports.some((p) => p.port === 5432 && p.label === "PostgreSQL"));
});
test("the operating-system presets name what a Windows client, a Windows server and a Debian or Ubuntu machine have open, and no port is called two things", async () => {
const list = (await json<{ presets: Preset[] }>(await call("viewer", "GET", "/port-presets"))).presets;
const has = (name: string, protocol: string, port: number, label: string) => list.find((p) => p.name === name)!.ports.some((p) => p.protocol === protocol && p.port === port && p.label === label);
assert.ok(has("Windows client", "tcp", 445, "SMB") && has("Windows client", "tcp", 49664, "RPC (dynamic)") && has("Windows client", "udp", 5353, "mDNS"));
assert.ok(has("Windows server", "tcp", 389, "LDAP") && has("Windows server", "tcp", 9389, "AD Web Services") && has("Windows server", "udp", 67, "DHCP server"));
assert.ok(has("Debian / Ubuntu", "tcp", 22, "SSH") && has("Debian / Ubuntu", "udp", 41641, "Tailscale"));
for (const p of list) assert.ok(p.ports.length <= pp.MAX_PRESET_PORTS, p.name);
// Whichever preset names a port first (by name) is the one heard, so every preset that names the same port must say the same thing.
const said = new Map<string, string>();
for (const p of list) for (const e of p.ports) {
const key = `${e.protocol}:${e.port}`;
assert.equal(said.get(key) ?? e.label, e.label, `${key} is called two things (${p.name})`);
said.set(key, e.label);
}
});
test("an operator writes, changes and removes one; a viewer cannot; the name is unique whatever its case; what is not a preset is refused", async () => {
const mine = { name: "Media", ports: [{ port: 8096, protocol: "tcp", label: "Jellyfin" }, { port: 8989, label: "Sonarr" }] };
assert.equal((await call("viewer", "POST", "/port-presets", mine)).status, 403);
@@ -322,3 +338,30 @@ describe("the routes", () => {
});
});
});
describe("the operating-system presets on a list that is already in use", () => {
const names = async () => (await pp.listPresets()).map((p) => p.name).sort();
test("they are added once, beside what is there: a preset of the same name is left as it is, a deleted one is not put back, and an emptied list stays empty", async () => {
const { settings } = await import("../src/db/schema.js");
const forgetOsFlag = () => db.delete(settings).where(eq(settings.key, "_internal:portPresetsOsSeeded"));
// The list as an install from before them has it: five presets (one changed) and a flag for those five only.
await db.delete(portPresets);
const now = new Date().toISOString();
await db.insert(portPresets).values([
{ name: "Remote access", ports: JSON.stringify([{ port: 22, protocol: "tcp", label: "SSH" }]), createdAt: now, updatedAt: now },
{ name: "windows CLIENT", ports: JSON.stringify([{ port: 1, protocol: "tcp", label: "Mine" }]), createdAt: now, updatedAt: now },
]);
await forgetOsFlag();
assert.deepEqual(await names(), ["Debian / Ubuntu", "Remote access", "Windows server", "windows CLIENT"], "the missing ones came, the one with the same name (any case) did not");
assert.deepEqual((await pp.listPresets()).find((p) => p.name === "windows CLIENT")!.ports.map((p) => p.label), ["Mine"]);
for (const p of (await pp.listPresets()).filter((x) => x.name === "Debian / Ubuntu")) await db.delete(portPresets).where(eq(portPresets.id, p.id));
assert.deepEqual(await names(), ["Remote access", "Windows server", "windows CLIENT"], "deleted, and not put back");
await db.delete(portPresets);
await forgetOsFlag();
assert.deepEqual(await names(), [], "somebody emptied the list, so it stays empty");
assert.deepEqual(await names(), [], "and the next look is the same");
});
});