Unlink servers before deleting a Proxmox integration
servers.proxmox_integration_id was created (migration 0001) without an ON DELETE rule, although schema.ts asks for "set null", so with foreign keys on, deleting an integration that a server was linked to failed with a constraint error. The delete route now clears the four proxmox_* columns on those servers first and records how many it unlinked in the audit entry. schema.ts notes the gap. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
3035d7fc08
commit
86dfa9ae2e
2 files changed
+12
-2
No files matched your search
@@ -272,6 +272,14 @@ integrationsRouter.delete("/:id", requireRole("admin"), asyncHandler(async (req,
|
||||
return res.status(404).json({ error: "not_found" });
|
||||
}
|
||||
|
||||
// servers.proxmox_integration_id was meant to clear itself, but the database only has a plain REFERENCES on it (see
|
||||
// DATABASE.md), so a linked server would block the delete. Clear the whole link here — the four columns go together.
|
||||
const unlinked = await db
|
||||
.update(servers)
|
||||
.set({ proxmoxIntegrationId: null, proxmoxNode: null, proxmoxGuestType: null, proxmoxVmid: null })
|
||||
.where(eq(servers.proxmoxIntegrationId, id))
|
||||
.returning({ id: servers.id });
|
||||
|
||||
await db.delete(integrations).where(eq(integrations.id, id));
|
||||
if (existing.credentialId) {
|
||||
await db.delete(integrationCredentials).where(eq(integrationCredentials.id, existing.credentialId));
|
||||
@@ -283,7 +291,7 @@ integrationsRouter.delete("/:id", requireRole("admin"), asyncHandler(async (req,
|
||||
action: "delete",
|
||||
targetType: "integration",
|
||||
targetId: id,
|
||||
detail: { name: existing.name },
|
||||
detail: { name: existing.name, ...(unlinked.length > 0 ? { unlinkedServers: unlinked.length } : {}) },
|
||||
});
|
||||
|
||||
res.status(204).end();
|
||||
|
||||
Reference in new issue
Block a user